Fix handling of deleted TreeNodes #24345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: main
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/dds/tree/src/shared-tree/checkoutFlexTreeView.ts:73
- [nitpick] Consider using a more descriptive error message (e.g., 'View has already been disposed') to improve debugging clarity.
assert(!this.disposed, "disposed");
alexvy86
reviewed
Apr 11, 2025
packages/dds/tree/src/feature-libraries/flex-tree/flexTreeTypes.ts
Outdated
Show resolved
Hide resolved
…s.ts Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
alexvy86
approved these changes
Apr 14, 2025
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
daesunp
reviewed
Apr 15, 2025
| // Calling this is a performance improvement, however, do this only after demand to avoid momentarily having no anchors to anchorNode | ||
| anchorForgetters?.get(this.node)?.(); | ||
| if (!allowDeleted) { | ||
| assertFlexTreeEntityNotFreed(this.#hydrationState.innerNode); |
There was a problem hiding this comment.
Nit: unrelated to this PR, but should this function be renamed to assertFlexTreeEntityNotDeleted? The doc comment for the function also seems to say Assert entity is not deleted.
There was a problem hiding this comment.
in the flex tree abstraction, we have isFreed which this is referring to, so I think its fine. Probably would be nice to better along the terminology in the two layers though.
daesunp
approved these changes
Apr 15, 2025
This was referenced Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix invalid caching of TreeNodes across view disposal.
Fix asserts instead of usage errors when accessing disposed nodes.
Make errors more robust by centralizing error logic in node kernel's lookup.
Add some additional validation internally.
Clarify docs on TreeNodeStatus.Deleted
Reviewer Guidance
The review process is outlined on this wiki page.